Docs: Update the recommendation for the cadence of npm releases #35925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Developer Documentation
ryanwelcher
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm proposing we change the moment when npm publishing is performed in relation to the Gutenberg plugin release. It's a recurring issue that we run into conflicts in the CHANGELOG files because new changes get added between the plugin's RC1 and the actual release. When we publish to npm a week after the plugin's RC1 we often see newer entries attributed to the previous npm release. A recent example would be #35886.
If we would start doing npm publishing just after the release branch is created for the Gutenberg plugin we would completely remove the chances to mess up with entries in the CHANGELOG files. All changes applied to CHANGELOG files at the time npm publishing would get cherry-picked before any new unreleased entries would get added from the in-progress PRs. In addition to that, the most important is the quality of the Gutenberg plugin and WordPress core so we can consider publishing to npm earlier as a another way to catch any integration issues early on.