Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Comments: Even out the top margin inside the block #35887

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Post Comments: Even out the top margin inside the block #35887

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d597ff
Clear the margin at the top of the comment reply title
kjellr Oct 22, 2021
8eaf064
Remove top margin from nocomments as well.
kjellr Oct 22, 2021
2ea2c06
Target just the first h3.
kjellr Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/block-library/src/post-comments/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
.wp-block-post-comments {
.comment-reply-title,
.nocomments {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If #35743 merges, I don't think .nocomments will ever appear. That said, I think zero'ing the margin for the reply title is an improvement.

Also I tested this PR and 2022, if I go to a post with existing comments and comments turned off, this is what appears:

Screen Shot 2021-10-26 at 9 39 34 AM

I thought maybe the "Comments are closed" message would appear, but it does not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch. I updated the PR to just target the first h3 in there instead.

margin-top: 0;
}

.commentlist {
list-style: none;
margin: 0;
Expand Down