Core Data uses hardcoded baseURL prefix for taxonomies and post types #35850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
added
[Type] Bug
spacedmonkey
commented
Oct 21, 2021
|
Related: #35846 |
|
Size Change: +10 kB (+1%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
|
Prettier complains about whitespaces:
|
gziolo
approved these changes
Oct 22, 2021
swissspidy
reviewed
Oct 25, 2021
swissspidy
reviewed
Oct 25, 2021
|
@gziolo As there is a conditional chaining here, this change is safe to merge now. It should fallback to |
|
I'd probably wait with merging this one until the core patches have been committed, so that this change can be tested with trunk. |
|
Is it possible to pull from the items response link instead? |
Nope, the links contains the full url. Which is not what we need in this context. |
|
Gotcha. Do we have the REST API base URL available at this point? |
I don't know a simple way of doing this. Maybe someone like @gziolo could answer this. |
aristath
approved these changes
Nov 1, 2021
The response of the endpoint |
Sorry, I think the question wasn't clear. In a javascript context, is there a simple way of getting the base url for the REST API, so http://www.example.com/wp-json? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upstream change #53656 #54267
In the above upstream changes, the namespace is returned as part of the REST API response, this field is present in the response, otherwise default to wp/v2.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).Fixes #33420