Border Radius Control: Add fallback px unit and add utils tests #35786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Feature] Inspector Controls
7 tasks
|
Size Change: +9 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
This looks great @andrewserong ✨
Love the extra test coverage. I think I found a small typo but other than that this LGTM 👍
✅ Code changes and tests look good
✅ All new tests pass
✅ No regression for the bug fix from #35651
✅ Split radius values continue to work correctly
packages/block-editor/src/components/border-radius-control/test/utils.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Robertshaw <[email protected]>
andrewserong
deleted the
update/border-radius-control-add-utils-unit-tests
branch
|
Thanks a lot for the follow-up, @andrewserong! The added test coverage is amazing 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on feedback from @ockham, this PR re-implements the fix in #35651 for the Border Radius Control's fallback to
pxunits, by moving the fix to thegetAllUnitutils function. The changes here include:pxfallback togetAllUnit.utilsmodule.modefunction to sort most common elements to the beginning of the array, and return the first element, to account for Array.sort() behaviour that always sortsundefinedto the end of an array.exportto themodefunction so that we can test it directly.How has this been tested?
41undefinedin the code editor view)Screenshots
Types of changes
Non-breaking code quality change.
Checklist:
*.native.jsfiles for terms that need renaming or removal).