Heading: Remove anchor map when block unmounts #35761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Heading
|
Size Change: +7 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Oct 19, 2021
|
Thanks, Nik. I also noticed the "undo trap" as well after creating this PR. I'll have another one ready for it shortly 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Viewing Header block transformation adds anchor to the object map. Therefore, it can cause incorrect anchor generation when the block is transformed.
PR adds
useEffectcleanup to remove the mapping.I noticed this issue while investigating flaky Quote block tests.
To reproduce failing tests, run e2e in interactive mode on
trunk:Fixes #35623.
Fixes #35644.
Fixes #35707.
Fixes #35748.
How has this been tested?
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).