Heading: Auto-generated anchors hide implementation details #35747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Heading
|
Size Change: +8 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
@aristath, I noticed that we have new "flaky" tests after we merged this feature. The good news is that I think I've got a solution for them 😄 |
|
I'm trying to understand the reason behind this PR... Is its sole purpose to move the |
|
Mostly moving implementation details in the same file. It's similar to how we use map objects in the |
Mamaduka
force-pushed
the
update/autogenerate-anchors
branch
from
d909f2d to
b8955a8
Compare
Mamaduka
force-pushed
the
update/autogenerate-anchors
branch
from
b8955a8 to
e850edd
Compare
|
Hi, @aristath Should we merge this update or leave it as it is? |
I see no harm in it |
aristath
approved these changes
Oct 25, 2021
Mamaduka
force-pushed
the
update/autogenerate-anchors
branch
from
e850edd to
e738290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #30825.
Hides implementation details from the Heading edit component.
How has this been tested?
This doesn't change now auto-generating anchors work. You can find original testing instructions in the main PR - #30825.
Types of changes
Code Quality
Checklist:
*.native.jsfiles for terms that need renaming or removal).