Post editor: Add some top margin. #35717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
jasmussen
commented
Oct 18, 2021
| @@ -44,7 +44,8 @@ | |||
| margin-right: auto; | |||
| } | |||
|
|
|||
| margin-top: var(--wp--style--block-gap); | |||
| // Add extra margin at the top, to push down the Title area in the post editor. | |||
| margin-top: max(var(--wp--style--block-gap, #{ $grid-unit-10 * 8 }), #{ $grid-unit-10 * 8 }); | |||
There was a problem hiding this comment.
This creative rule exists to thread the needle between themes that have a block gap defined, themes that don't, and themes that have a block gap higher than 64px, letting that shine through.
Two alternatives:
- Don't worry about themes with post title margins higher than 64px, and just bake it to
margin-top: $grid-unit-10 * 8; - Use rems, such as
margin-top: 4rem;
Happy to change to either. Thoughts?
|
Size Change: +1 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
I don't have opinion here, I wonder whether using |
|
Let me try rems, just to see how that feels. This does sort of straddle the line between UI and theme, though. |
|
4 rems, feels good:
|
youknowriad
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #35426. The top margin in the post editor above the title can be a bit small:
The post editor, unlike the Site Editor, should cater just a little bit more to the writing experience, and pushing the site title down just a bit feels worth it:
Also tested this with tt and tt1:
And tt1 blocks:
How has this been tested?
Create a new post and observe the post title in the post editor pushed down to a comfortable place.
Checklist:
*.native.jsfiles for terms that need renaming or removal).