Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs and readme post merge of #35645 #35679

Merged
merged 4 commits into from
Oct 15, 2021
Merged

Update docs and readme post merge of #35645 #35679

merged 4 commits into from
Oct 15, 2021

Conversation

ryanwelcher
Copy link
Contributor

Description

Adds updates to CHANGELOG and README files to reflect changes merged with #35645

Screenshots

Types of changes

Documentation and changelog.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@ryanwelcher ryanwelcher added [Type] Enhancement A suggestion for improvement. [Type] Developer Documentation Documentation for developers [Tool] Create Block /packages/create-block labels Oct 15, 2021
jorgefilipecosta
jorgefilipecosta approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

packages/create-block/CHANGELOG.md Outdated
@@ -3,6 +3,7 @@
## Unreleased

### New Features
- Add passing local directories to --template. ([#35645](https://github.com/WordPress/gutenberg/pull/35645))
- Add `slugPascalCase` to the list of variables that can be used in templates ([#35462](https://github.com/WordPress/gutenberg/pull/35462))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we correct the indentation of this line below to also be 4 spaces?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Looks like my IDE got me :)

@ryanwelcher ryanwelcher merged commit bae1030 into WordPress:trunk Oct 15, 2021
@ryanwelcher ryanwelcher deleted the feature/update-docs-post-35645-merge branch October 15, 2021 17:10
@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 15, 2021
This was referenced Oct 22, 2023
Open
Open
@soloinovator soloinovator mentioned this pull request Oct 22, 2023
Open
This was referenced Oct 22, 2023
Open
Open
@npneeraj npneeraj mentioned this pull request Oct 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@gziolo gziolo Awaiting requested review from gziolo gziolo is a code owner

@mkaz mkaz Awaiting requested review from mkaz

Assignees
No one assigned
Labels
[Tool] Create Block /packages/create-block [Type] Developer Documentation Documentation for developers [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 11.8
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanwelcher @jorgefilipecosta