-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation note for Home/end to avoid mistranslations. #35669
Conversation
Should fix #35608 , this is my first time I did a translation note ... So feedback is welcome. Line 134 added.
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @NekoJonez! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Thx to the feedback, I placed the translation note on a better place. I also formatted the code a bit better so that it looks like the last one.
Hi, @NekoJonez Try running |
I only work in the browser... So, running commands isn't possible for me :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I fixed those on my end 👍
I will try to merge this once all checks are green. Thanks for contributing, and congratulations on your first PR 🎉
Excellent! Thanks my man! Btw, is this translation note also going to WP core? Since, the strings are already in core and it would be a shame if we avoid mistranslations in Gutenberg and not in Core for the same strings and features. |
Yes, this change will be part of 5.9. |
Lovely! A polygot job well done me thinks! |
Description
Should fix #35608 , this is my first time I did a translation note ... So feedback is welcome.
Types of changes
Line 134 added.