Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation note for Home/end to avoid mistranslations. #35669

Merged
merged 4 commits into from
Oct 15, 2021

Conversation

NekoJonez
Copy link
Contributor

Description

Should fix #35608 , this is my first time I did a translation note ... So feedback is welcome.

Types of changes

Line 134 added.

Should fix #35608 , this is my first time I did a translation note ... So feedback is welcome. Line 134 added.
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @NekoJonez! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 15, 2021
Thx to the feedback, I placed the translation note on a better place. 
I also formatted the code a bit better so that it looks like the last one.
@Mamaduka
Copy link
Member

Hi, @NekoJonez

Try running npm run format-js after the changes, it should fix all the linting issues.

@NekoJonez
Copy link
Contributor Author

Hi, @NekoJonez

Try running npm run format-js after the changes, it should fix all the linting issues.

I only work in the browser... So, running commands isn't possible for me :/

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I fixed those on my end 👍

I will try to merge this once all checks are green. Thanks for contributing, and congratulations on your first PR 🎉

@NekoJonez
Copy link
Contributor Author

No worries, I fixed those on my end 👍

I will try to merge this once all checks are green. Thanks for contributing, and congratulations on your first PR 🎉

Excellent! Thanks my man!
And happy to help.

Btw, is this translation note also going to WP core? Since, the strings are already in core and it would be a shame if we avoid mistranslations in Gutenberg and not in Core for the same strings and features.

@Mamaduka
Copy link
Member

Btw, is this translation note also going to WP core?

Yes, this change will be part of 5.9.

@NekoJonez
Copy link
Contributor Author

Btw, is this translation note also going to WP core?

Yes, this change will be part of 5.9.

Lovely! A polygot job well done me thinks!

@Mamaduka Mamaduka merged commit af91449 into WordPress:trunk Oct 15, 2021
@Mamaduka Mamaduka added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Oct 15, 2021
@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 15, 2021
@NekoJonez NekoJonez deleted the patch-1 branch October 15, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation note requested
2 participants