Navigation: Fix submenus not showing on click. #35660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -10 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
I realized as I was working on this one, that we aren't very well handling nested submenus when the ancestor is set to open in click. It works, but the nested container of the submenu absorbs the click entirely, making its destination unreachable. This was an intentional trade-off for the top level item, but submenus probably need a different solution, such as always opening on hover/focus. I'll explore that separately. |
7 tasks
|
Closing this one in favor of #35716, which does the same and more, but better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #35654. Maybe related to #35653.
Nested submenus did not show up when the navigation block was set to open on click. This was due to CSS that applied
overflow: hidden;on submenus, "cropping off" the nested submenu. This PR fixes that:The visual style discrepancy in the above is unrelated to the issue, the theme in question styles the
a, but not thebutton.How has this been tested?
Create a menu with submenus and nested submenus. Ensure all pages added are published, not drafts. Set the menu to open on click:
Here's some test content:
Please test that both in the editor and on the frontend, nested submenus open as intended, on click.
Hover should be unaffected, but for good measure, test that hover/focus to open nested submenus works as well.
Checklist:
*.native.jsfiles for terms that need renaming or removal).