Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default value of the viewportWidth attribute in documentation #35659

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

fabiankaegy
Copy link
Member

Description

As defined in the code here:

the default should be 1200 instead of 700

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@fabiankaegy fabiankaegy added the [Type] Developer Documentation Documentation for developers label Oct 15, 2021
@fabiankaegy fabiankaegy self-assigned this Oct 15, 2021
@fabiankaegy fabiankaegy requested a review from ellatrix as a code owner October 15, 2021 07:11
@fabiankaegy fabiankaegy added the [Package] Block editor /packages/block-editor label Oct 15, 2021
@fabiankaegy fabiankaegy requested a review from gziolo October 15, 2021 08:12
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ntsekouras ntsekouras merged commit b42e454 into trunk Oct 15, 2021
@ntsekouras ntsekouras deleted the fix/block-preview-documentation-patch-1 branch October 15, 2021 08:17
@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block editor /packages/block-editor [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants