Embed: Add Wolfram Cloud as an embed provider #35656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pento
added
[Type] Enhancement
|
Size Change: +10.1 kB (+1%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
|
Thanks for the PR @pento ! A provided example link would be great for testing purposes - I created an account there to test and I'm still not sure if I published a 'right' thing there 😄 Since the provider is to be included in Also I'm wondering how this should be handled best as the plugin supports two WP versions behind.. Anyone knows how similar cases were handled? Maybe for --cc @gziolo |
|
Thanks for testing, @ntsekouras. The Wolfram Physics Project is a good source for test pages: pretty much any page will have a "Open in Wolfram Cloud" link at the bottom. With the WordPress 5.9 feature freeze coming up, this needs to be merged ASAP. I don't recall seeing problems in the past of people trying to use embeds in the plugin before the appropriate Core version is released. |
andrewserong
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following on from Wolfram Cloud being added as a trusted embed provider to WordPress Core (WP53326), this PR adds Wolfram Cloud as an embed block provider.
The Wolfram icon comes from their website, it's a simplified version of their main icon.
How has this been tested?
Screenshots
Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).