-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Themes: Support title in templateParts #35626
Conversation
It should work on the Gutenberg/WordPress core side, but we also will have to open a patch against WP-CLI to update the i18n schema used there. Edit: it looks like it should be automated now: |
Great news. Thanks, @gziolo. |
There is another unit test that covers translations in |
@gziolo, how do you update language files for the test theme? |
@gziolo figured it out. P.S. Sorry about my Polish; I had to use a google translator. |
Good job updating the test 👍 I guess the translation is correct 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good and it has enough test coverage 🚀
Description
Adds "title" support in
templateParts
theme.json configuration.Fixes #34723.
Cc @gziolo, I saw that you introduced i18n for the
customTemplates
title, and I just wanted to check if I'm handling it correctly here.How has this been tested?
templateParts
definition in theme, e.g. Blockbase.Example
Screenshots
Types of changes
Enhancement
Checklist:
*.native.js
files for terms that need renaming or removal).