Quote: update deprecation to expect style block supports #35615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we don't allow through an unwanted style attribute of `{ style: 1 }`.
ramonjd
added
Backwards Compatibility
7 tasks
|
Size Change: +19 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
Nice work on the quick fix here @ramonjd 🏅
✅ The fixture tests all pass for me
✅ Manually pasting deprecated block markup gets successfully migrated
✅ Loading old post with deprecated content still works as expected
This all looks good to me 👍
One tiny suggestion ( please feel free to ignore ) is that now might be a good opportunity to omit the omit from these deprecations and use the rest operator instead. I'll leave that call to you 🙂
|
Thanks for the review! 🙇
Good suggestion. Nothing gives me more pleasure than replacing lodash methods. eslint nags about the unused destructured var (no-unused-vars) We could delete the prop: const newAttributes = {
...attributes,
};
delete newAttributes.style;
return newAttributes;Maybe I can raise this in one of the channels and see what the preference would be across the repo. I'll put my hand up to do a lodash cull. 😄 |
ramonjd
deleted the
update/core-quote-block-deprecation-for-style-supports
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Over at #34064, we were hoping to add typography block supports to the Quote Block.
Then we ran into 😱
Long ago, in the dark times, the quote block did have an attribute of
{ style: 1 }to dictate a particular UI block style, e.g., Large or Cheese-Streamers-With-Comic-Sans.To avoid the legacy
styleattribute hanging around, the Quote Block deprecations needs a teensy tweak to ensure the block is correctly migrated when we it opts-in to block supports that rely on a style attributeHow has this been tested?
Run
npm run fixtures:generate. The tests should pass.If you want to check manually, activate TT1 blocks.
In
quote/block.json, opt-in to any of the following block supports for the Core Quote Block:You might have to enable support in your
theme.jsonfile as well, e.g.,In the Block Editor code view field, paste the contents of core__quote__deprecated.html
It should match the contents of core__quote__deprecated-1.serialized.html
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).