Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates react-native-aztec android to use S3 dependency for Aztec editor #35606

Merged
merged 3 commits into from
Oct 14, 2021

Conversation

oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented Oct 13, 2021

Description

wordpress-mobile/AztecEditor-Android#941 adds support for publishing AztecEditor-Android to our s3 maven repository. This PR updates react-native-aztec android library to fetch this dependency from S3 instead of Jitpack. It also re-orders to repositories for react-native-aztec so we don't depend on deprecated jcenter repository for any dependency that's published elsewhere.

I'll create a new v1.4 tag for the AztecEditor-Android library and update react-native-aztec before we merge this in.

How has this been tested?

I've tested the WPAndroid integration wordpress-mobile/WordPress-Android#15457 and I was hoping @mchowning could help me test the demo app.

Types of changes

Build file changes for react-native-aztec android.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@oguzkocer oguzkocer added [Type] Build Tooling Issues or PRs related to build tooling Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Oct 13, 2021
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@oguzkocer oguzkocer marked this pull request as ready for review October 14, 2021 20:20
@oguzkocer oguzkocer merged commit 54d5faa into trunk Oct 14, 2021
@oguzkocer oguzkocer deleted the update-aztec-android-to-1.4 branch October 14, 2021 22:45
@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants