Convert usePrevious hook to TypeScript.
#35597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Code Quality
ZebulanStanphill
changed the title
usePrevious hook to TypeScript.
|
Size Change: -3 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
sarayourfriend
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
LGTM! Though just for the record I think this falls under refactoring for refactoring's sake (which is against the WP coding guidelines). Uplifting code that currently isn't type checked (either using JSDoc or TypeScript) is definitely more desirable than converting JSDoc checked files to native TypeScript.
But anyway, this code is definitely a lot cleaner and more comprehensible than the JSDoc version, so thank you 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #18838.
Using TypeScript, we can get rid of a type assertion in the
usePrevioushook, and even avoid explicitly passingundefinedto the initialuseRefcall, so that's what I did in this PR. The implementation is now more or less identical to theusePrevioushook in several other projects:useIsomorphicLayoutEffectrather thanuseEffect, which is interesting)Checklist:
*.native.jsfiles for terms that need renaming or removal).