Enable/skipped metabox test #35594
Merged
Enable/skipped metabox test #35594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
|
Hi, @JustinyAhin thanks for working on this. Let's restart e2e tests 2-3 before we merge this PR. It often happens that tests are working locally but fail on GitHub CI. |
I think it is good to go @Mamaduka I've restarted the e2e tests a couple of times. |
Mamaduka
approved these changes
Oct 14, 2021
|
Thanks, @JustinyAhin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #32034.
How has this been tested?
Run
npm run test-e2e -- packages/e2e-tests/specs/editor/plugins/meta-boxes.test.jslocally and check the changed test still passes.Use
for i in {1..5}; do npm run test-e2e -- packages/e2e-tests/specs/editor/plugins/meta-boxes.test.js; doneto run the test file 5 times, for instance.Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).