Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Add CHANGELOG entry for the fieldset removal from FontAppearanceControl #35585

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Oct 13, 2021

Description

Small follow-up of #35461 adding a CHANGELOG entry

How has this been tested?

This PR doesn't introduce any runtime changes.

Types of changes

Docs update (CHANGELOG)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@ciampo ciampo added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components [Feature] Component System WordPress component system labels Oct 13, 2021
@ciampo ciampo requested a review from mirka October 13, 2021 09:53
@ciampo ciampo requested a review from ajitbohra as a code owner October 13, 2021 09:53
@ciampo ciampo self-assigned this Oct 13, 2021
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Should we put it under an ### Experimental heading since this is still in the experimental stage?

export { default as __experimentalFontAppearanceControl } from './font-appearance-control';

@ciampo
Copy link
Contributor Author

ciampo commented Oct 13, 2021

Absolutely, the lack of a README made me skip the check to see if this component is experimental. Thank you for catching this!

@ciampo ciampo merged commit e5c833a into trunk Oct 14, 2021
@ciampo ciampo deleted the docs/components-changelog-font-appearance-control-fieldset-removal branch October 14, 2021 07:27
@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Component System WordPress component system [Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants