-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new color picker props #35566
Merged
jorgefilipecosta
merged 1 commit into
trunk
from
update/remove-deprecated-color-picker-properties
Oct 15, 2021
Merged
Use new color picker props #35566
jorgefilipecosta
merged 1 commit into
trunk
from
update/remove-deprecated-color-picker-properties
Oct 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Code Quality
Issues or PRs that relate to code quality
label
Oct 12, 2021
jorgefilipecosta
requested review from
ajitbohra and
chrisvanpatten
as code owners
October 12, 2021 17:21
jorgefilipecosta
force-pushed
the
update/remove-deprecated-color-picker-properties
branch
from
October 12, 2021 17:26
7e2dd80
to
f12c71d
Compare
Size Change: -16 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
jorgefilipecosta
changed the title
Use new color picker props; Fix some issue on the color picker component.
Use new color picker props
Oct 12, 2021
jorgefilipecosta
force-pushed
the
update/remove-deprecated-color-picker-properties
branch
from
October 12, 2021 18:30
f12c71d
to
a086f30
Compare
jorgefilipecosta
force-pushed
the
update/fix-issue-on-color-picker-component-remove-tiny-color
branch
5 times, most recently
from
October 15, 2021 12:49
45e71e7
to
8706c2d
Compare
Base automatically changed from
update/fix-issue-on-color-picker-component-remove-tiny-color
to
trunk
October 15, 2021 12:54
jorgefilipecosta
force-pushed
the
update/remove-deprecated-color-picker-properties
branch
from
October 15, 2021 13:06
a086f30
to
62e3b2e
Compare
jorgefilipecosta
force-pushed
the
update/remove-deprecated-color-picker-properties
branch
from
October 15, 2021 14:49
62e3b2e
to
c19d239
Compare
jorgefilipecosta
deleted the
update/remove-deprecated-color-picker-properties
branch
October 15, 2021 15:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our codebase to stop using deprecated ColorPicker properties.
How has this been tested?
I verified the custom color picker still works as expected on the color palette, global styles palette editor, and the custom gradient picker.