Update range control metrics #35540
Merged
Update range control metrics #35540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
approved these changes
Oct 12, 2021
|
Size Change: -3 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The range control/slider was recently polished to have a smaller visual footprint:
However a bug in Chrome means we can't have a 3px tall slider track, and a proper rounded border radius as a radius of 1.5px is rounded down to 1px. So the track was made 4px tall. However with a 9px tall knob, that made the knob offset.
This PR updates the design of the slider based on new metrics from the Global Styles figma.
That means a 12px knob:
And 20px focus style:
How has this been tested?
Insert a gallery, try the range control in the inspector.
Checklist:
*.native.jsfiles for terms that need renaming or removal).