Fix taxonomies flaky tests #35534
Merged
Fix taxonomies flaky tests #35534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinyAhin
added
[Package] E2E Tests
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
youknowriad
approved these changes
Oct 12, 2021
|
The new selector is not found https://github.com/WordPress/gutenberg/pull/35534/checks?check_run_id=3867770004#step:6:60 🤔 |
|
Hi, @JustinyAhin The sector should be correct. The P.S. I changed that selector in #33545. |
Hey @Mamaduka Here is what is currently outputted |
|
Here is the markup I see on the current Gutenberg
Also, looking at the failure artifacts from the issue, it seems that the "Categories" panel isn't open, and I think that's the cause of the e2e test failure.
|
|
It seems it's open but the categories are not loaded yet, maybe a missing waitForSelector somewhere? |
Yes, we could probably wait for |
|
Most likely, this condition is true at the time test is trying to click on "Add new category." I simulated this scenario and got the visually same result @JustinyAhin that check might help, so code waits a little more before |
|
@Mamaduka I think I might have one issue with my setup. I've just deleted my Gutenberg folder, clone and build again. But the input still have this class name: |
|
@JustinyAhin, sorry, I know this sounds silly, but can you check if the Gutenberg plugin is active on the test setup? It happened to me more than once 😅 |
🤦🏻♂️🤦🏻♂️ oh it was that 😅 |
@Mamaduka could you explain this a bit more for me please? |
|
@JustinyAhin it might take some time for |
|
@Mamaduka this is ready to go. Maybe you can look one last time? :) |
Mamaduka
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
Thanks for the ping, @JustinyAhin. I think this looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #35483.
The test fail was due to a wrong selector.
.editor-post-taxonomies__hierarchical-terms-input input[type=text]was used before. This will look for a text input inside the element with the class.editor-post-taxonomies__hierarchical-terms-input. While the input itself has this class name.How has this been tested?
Run
npm run test-e2e -- packages/e2e-tests/specs/editor/various/taxonomies.test.jslocally and check the changed test still passes.Use
for i in {1..5}; do npm run test-e2e -- packages/e2e-tests/specs/editor/various/taxonomies.test.js; doneto run the test file 5 times for instance.Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).