Featured image block and Image blocks: remove descendent space #35466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
added
[Block] Image
|
Size Change: +57 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
I wasn't even aware of this issue, and now I dearly want it fixed, so thanks so much for tackling this one. I can confirm that trunk shows that extra space for the Image block: I can also confirm this branch fixes it:
I wasn't personally familiar with the vertical-align trick leveraged here, my instinct would naturally be to go towards the line-height fix as I've used that for similar situations in the past. What's the benefit of the vertical align trick, and are there any side effects to maybe be aware of? |
|
hi, @jasmussen thanks for having a look! To be honest I'm not sure what is the best solution here. I'm reading more about the origin of the problem here and it recommends using I could only thing of this maybe affecting the gallery block but it seems like there the fix is doing nothing because the gallery is already using flexbox (using anything except inline/inline-block would solve the issue). It looks the same with or without the fix: What I've seen is that we can't make the line height solution on the image block cause it messes up the caption:
|
jasmussen
approved these changes
Oct 11, 2021
|
Thanks Joen, I'll bring this in then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an alternative to #35273 while also applying it to the Image block, who also has that unwanted space between figure and image tags.
How has this been tested?
Insert the blocks on emptytheme, check that there's no space between the figure tag and the image tags.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).