-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Settings: Don't render 'Move to' if the block cannot be moved #35463
Conversation
Size Change: -11 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally and can confirm that it is working as expected. The code also looks good to me. I'll leave approval to one of the maintainers that were pinged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and works as expected ✅
Description
Replaces
isLocked
check withcanMoveBlocks
, latter considers the template lock.Part of #29864.
P.S. I also update
useSelect
calls to use the new selector getter method.How has this been tested?
Locked block
Screenshots
Types of changes
Bugfix
Checklist:
*.native.js
files for terms that need renaming or removal).