Add template details to template parts #35444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Feature] Template Editing Mode
kevin940726
requested review from
adamziel,
getdave,
noisysocks,
talldan,
jameskoster,
tellthemachines and
anton-vlasenko
|
Size Change: +184 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
kevin940726
force-pushed
the
add/template-details-for-template-part
branch
from
fa74c50 to
2863123
Compare
noisysocks
approved these changes
Oct 8, 2021
|
For template parts, I am seeing the blue focus outline applied around the clear customization button as soon as I open the dropdown, so I wonder what I am doing differently. Wishlist: |
|
@carolinan That's because the button is the first focusable element in the dropdown, and it should be auto-focused when the dropdown is opened the first time. I should probably add some padding around it though so that it looks less weird. IIRC, the term "template part" is supposed to be a technical detail and shouldn't be user-facing. We could somehow reword this though, open to ideas! |
|
It is the name of the block though so it is already user facing 🤔 .That is indeed a bigger discussion. |
|
So I fixed the styling, it now looks like this:
|
carolinan
approved these changes
Oct 8, 2021
|
I noticed the template part name in the top bar is using the slug, while the popover uses the name, which can lead to awkward discrepancies like so:
It may be worth fixing that here? Can we make the "Browse all templates" button contextual? IE if I'm editing a |
noisysocks
approved these changes
Oct 12, 2021
kevin940726
force-pushed
the
add/template-details-for-template-part
branch
from
028b9d3 to
1523e4f
Compare
kevin940726
force-pushed
the
add/template-details-for-template-part
branch
from
1523e4f to
b930f2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #29687. Add template details dropdown to template parts. There's also a revert button in the dropdown.
How has this been tested?
tt1-blocksScreenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).