Try another fix for flaky nav test. #35443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
ajitbohra,
nerrad and
ntwb
as code owners
tellthemachines
added
[Block] Navigation
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
|
So did the e2e test catch a bug? Has that been reported anywhere? |
If the behaviour described in the comment I linked above is a bug, and if that's what is causing the flakiness, then I guess so. Though the comment is a few months old, there doesn't seem to be an issue, but I can reproduce the behaviour on trunk by opening the block library and then clicking an appender straightaway. The appender becomes focused, and the library sidebar closes, but quick inserter doesn't open. I'm not even sure if we're having the same issue here, but the failure screenshots show the quick inserter is not open, and either the inserted block or the appender are focused. The appender is always visible, which means it must be the click action on it that's not working for some reason. |
|
Testing behavior with the Global Inserter, whether or not this fails likely depends on how quickly the sidebar closes. If it's still open and we target the inserter, it'll close the sidebar instead of opening the quick inserter. The proposed changes here may work, but it might be better to fix the following. CleanShot.2021-10-11.at.13.28.41.mp4For other reviewers, here's what a local run looks like, using CleanShot.2021-10-11.at.13.26.52.mp4 |
To be clear, you mean fixing things so the quick inserter opens even if the block library sidebar is still open? |
|
I'm sure I recall @draganescu previously fixing the issue shown in that first video, but maybe it was reverted? edit: possibly #18379? |
💯 probably worth taking a quick look to see if it's reasonable, otherwise I think this change is fine to try. I'll give you a tentative ✅ on this PR so you can land this one if needed. |
gwwar
approved these changes
Oct 12, 2021
I don't think it's quite the same issue; here it's the block library sidebar that hijacks any click on the content area to close itself. It doesn't just happen with quick inserter, but also e.g. when clicking "options" on a block toolbar. |
|
So I looked into the library sidebar/inserter issue a bit, and wrote out #35575 with my conclusions. There may be better fixes than the one I described there, and I'm not sure we really want to change how the sidebar works in the library, so will wait for some feedback on that. In the meantime, I'll go ahead and merge this fix to see if we can at least reduce test flakiness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying another fix for #35235. Based on this comment, I'm thinking it might be the same problem, because we're also trying to click the block appender after closing the global inserter here.
How has this been tested?
Run e2e tests for
specs/experiments/blocks/navigation.test.jsand check they pass.Restart e2e tests a few times for this PR to see if the flaky test fails.
Screenshots
Types of changes
Bug fix (non-breaking change which (hopefully) fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).