Fix: Prevent empty renders in ServerSideRender component caused by changing props while already fetching markup #35433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiankaegy
added
[Type] Bug
fabiankaegy
changed the title
|
Size Change: +128 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Oct 7, 2021
ZebulanStanphill
approved these changes
Oct 8, 2021
adamziel
pushed a commit
that referenced
this pull request
Oct 13, 2021
…anging props while already fetching markup (#35433)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the way the
ServerSideRendercomponents stores the markup from previous renders and keeps track of loading state to fix #35406How has this been tested?
Using
wp-envlocally with the "Latest Comments" BlockTypes of changes
Bug Fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).Closing: #35406