Site Logo: Move Reset button to the Replace menu dropdown #35372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +71 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
I am unsure about the trashcan icon. It makes me wonder if the image is also deleted from the media library. |
|
I agree with @carolinan. We have the |
andrewserong
reviewed
Oct 6, 2021
There was a problem hiding this comment.
Just adding that this change is testing nicely for me, I like the addition of allowing children in the MediaReplaceFlow component, and it doesn't appear to cause any issues for any of the existing usages of that component (tested File, Image, Media & Text block, etc).
Other than the decision surrounding which icon to use that the others mentioned above, this change LGTM!
Good points -- this would also go further to mimic the appearance of
|
|
Nice, fast work! I don't think the minus button works well in this context. It works best when an item was added with the Plus icon first. I wonder if we can't just do what we do for blocks, where the "Remove" item doesn't have an icon at all. Like so: |
|
@jasmussen, I like the idea of having a separate group for "Reset." I can do a follow-up PR later today. |
|
It's in hyperoptimization territory, not urgent, just nice. Thanks as always for looking! |
|
I want to join the department of subtleties, so it’s not a problem :) |
|
I already consider you an honorary member 🚀 |
This was referenced Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a quick follow-up to #34820, which added a Reset button to the Site Logo block toolbar which clears the media. The original design gives the Reset button high prominence, so this PR just moves it from the top level of the block toolbar into the
Replacedropdown menu as a new option.How has this been tested?
Manually using the same testing instructions from #34280 and verifying that the Reset button now appears as a new menu item under
Replace(see screenshots).Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).