Post Title: Fix argument numbering in 'sprintf' #35338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Post Title
ntsekouras
reviewed
Oct 5, 2021
| @@ -29,7 +29,7 @@ function render_block_core_post_title( $attributes, $content, $block ) { | |||
|
|
|||
| $title = get_the_title( $post_ID ); | |||
| if ( isset( $attributes['isLink'] ) && $attributes['isLink'] ) { | |||
| $title = sprintf( '<a href="%1s" target="%2s" rel="%3s">%4s</a>', get_the_permalink( $post_ID ), $attributes['linkTarget'], $attributes['rel'], $title ); | |||
| $title = sprintf( '<a href="%1$s" target="%2$s" rel="%3$s">%4$s</a>', get_the_permalink( $post_ID ), $attributes['linkTarget'], $attributes['rel'], $title ); | |||
There was a problem hiding this comment.
Isn't this needed only if we reuse some arguments? If we use them just once (like here) and the order is correct the $ can be omitted, no?
There was a problem hiding this comment.
It's usually good practice to use them anyway, to avoid bugs in the future. This code was already using them, but with an incorrect format - %1s, the $ was missing.
There was a problem hiding this comment.
That what I meant - that the $ was not needed here. The % is needed and was there. Having said that I have no strong opinions on this one 😄
There was a problem hiding this comment.
I think there was WPCS rule for it, but can find it right now 😅
ntsekouras
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fixes argument numbering for
sprintfin Post Title block's link markup.Source: php.net: sprintf
How has this been tested?
Check linked post title block renders correctly.
Types of changes
Code Quality
Checklist:
*.native.jsfiles for terms that need renaming or removal).