Remove duplicated className in Card component #35333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Code Quality
|
Size Change: +13 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cardhas a duplicated classname "components-card". It comes about because it gets one from theuseContextSystemhook:gutenberg/packages/components/src/card/card/hook.js
Line 53 in f45dce1
Then it adds another:
gutenberg/packages/components/src/card/card/hook.js
Lines 62 to 63 in f45dce1
This PR simply removes the latter.
Snapshots for Card and Flyout needed updating as well. Those are better than the screenshot for evidence that there is a duplicate classname.
How has this been tested?
Manually verifying that "components-card" appears only once in the class attribute.
Screenshots
Before: duplicated classname 'components-card' shown in inspector
Types of changes
Code quality
Checklist:
*.native.jsfiles for terms that need renaming or removal).