-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a beta indicator for the global styles sidebar #35219
Conversation
@@ -65,3 +65,15 @@ | |||
.edit-site-global-styles-color-palette-panel { | |||
padding: $grid-unit-20; | |||
} | |||
|
|||
.edit-site-global-styles-sidebar__beta { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be some kind of pill component maybe or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe @sarayourfriend started working on a Tag
component, but the PR (#32214) was closed prematurely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @mtias and @jasmussen in case they have more to add on such a potential component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super temporary, we'll remove it shortly. It doesn't even need to be rendered as a tag, can be just Styles (Beta)
in text. If we consider using it more for specific blocks and in the long term we can revisit.
Size Change: +88 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Right now, the text and the link color. |
@jasmussen, here's the original PR for Global Styles Preview - #34991. (Hope, it's proper direction). |
@jasmussen I think some of these changes would require changes to the styles of some components like Card that have CSS in JS styles. I think it should be fine to do but let's think about these things globally and not per case. I think you should feel free to open PRs about these and ping @ciampo in them (and me potentially) |
Yep, was definitely thinking of these happening as improvements to the components themselves, not one-offs. The line-height might be the exception, as I think it makes sense for Card and View components to inherit the line height of its context. But for this particular design with the 80px text needing to be vertically centered, it does feel like that (the |
Yes, @mtias suggested above that the "tag" or "pill" or whatever stays specific to this for now. So yeah I was more talking about the spacing and border for cards... |
Followup for the line height in #35244. |
Followup to the Card component in #35245. |
While we iterate during the 5.9 lifecycle, let's add a "beta" indicator to the global styles sidebar to clarify its status. Once it's a decent state for 5.9, we should be able to remove it.