Thunkify reusable-blocks store #35217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
the
[Feature] Synced Patterns
|
Size Change: -23 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
talldan
reviewed
Oct 1, 2021
| ] ); | ||
|
|
||
| return registry; | ||
| } | ||
|
|
||
| describe( 'Actions', () => { |
There was a problem hiding this comment.
So these seem more like integration tests now that the entire store is being tested. I quite like it, it feels more useful to test stores as a standalone module.
Is it worth still keeping separate unit tests for selectors and reducers given they are also tested here?
There was a problem hiding this comment.
Is it worth still keeping separate unit tests for selectors and reducers given they are also tested here?
I think it is worth it, it creates an easy path of zeroing-in on a problem: imagine the actions-related tests fail, but the selectors-related tests don't. Now we know the selectors are fine.
talldan
reviewed
Oct 1, 2021
| expect( updatedBlocks ).toHaveLength( 1 ); | ||
|
|
||
| // Delete random clientId before matching with snapshot | ||
| delete updatedBlocks[ 0 ].clientId; |
There was a problem hiding this comment.
I had a similar issue in another test and decided to do this:
updatedBlocks[ 0 ].clientId = `[${ typeof updatedBlocks[ 0 ].clientId }]`At least the test can assert the type of the property is correct. Not something required, but just thought I'd share.
There was a problem hiding this comment.
I like that idea! I ended up merging this PR as is, but I may follow up with that change. For sure it's something I'll use in the future, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the reusable-blocks data store to thunks.
I reworked the unit tests to check for outcomes instead of the specific flow we tested for inside of the generator.
How to test:
Open the post editor, create a reusable block, reload the page, convert back to static, create another one, delete it, and confirm everything worked as expected.