Navigation Screen: Truncate long menu names #35188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
adamziel,
draganescu,
getdave,
kevin940726,
talldan and
tellthemachines
as code owners
Mamaduka
added
[Feature] Navigation Screen
[Type] Bug
|
Size Change: +37 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
|
Thank you for working on this :D Tested this with gutenberg.run and found it's not quite truncating the initial setup name:
Made it longer for good measure:
It seems to be isolated to just that initial step:
|
|
I'm not sure if the issue is Here's a screenshot from my local env: |
javierarce
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
I couldn't reproduce the problem @annezazu found, the changes work for me 🚢
Updated: wait, ignore that… the overflow problem happens to me too when you enter a string that can't be broken. Adding a word-break: break-word; to the block placeholder label seems to fix the problem.
|
@javierarce, I just tested with Firefox and couldn't reproduce the word break issue. Let's merge this and follow up with the fix in separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Truncate long menu names after 24 characters.
P.S. We probably need to use a different approach for long menu names in the dropdown.
Partially fixes #34512.
How has this been tested?
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).