Add color icon. #35187
Merged
Add color icon. #35187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, can we replace the brush used right now in the Global Styles Sidebar? :) |
|
Good call. Before:
After:
|
youknowriad
approved these changes
Sep 28, 2021
|
You're just about my favorite reviewer, Riad! |
|
Size Change: +9 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
|
Truth is, you just saved me some work hours by doing this PR instead of me :) |
|
Always happy to help, and you're always welcome to delegate if you can, especially in icon cases. |
mtias
approved these changes
Sep 28, 2021
|
Just stumbled on this PR. There are a number of other icons missing from the library. Notably this "tip" icon at the bottom of the block inserter.
I would also love to see all the icons that are used in the core Social Icons block added as well. I can put together a PR if this is of interest. Let me know! |
|
Oh good catch @ndiego, I could've sworn that was an icon part of the library, but it does appear to just be an inline SVG. I'd be happy to review such a PR. I don't think we should add logos to the icon library, though. There are some challenges already with following logo brand guidelines and keeping up with maintenance, which is a burden I don't think should be put on the icon library. There are separate places to get logos in a react format, though, such as this one. |
|
Awesome, thanks. I'll get a PR put together in a day or so. And yeah, I definitely see your point about the Social Icons. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a "color" icon in the WordPress Design Library Figma, this one:
It hasn't yet been added to the library, but it will be needed for adding a Color option directly to the Cover block toolbar.
Checklist:
*.native.jsfiles for terms that need renaming or removal).