-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ItemGroup
: do not export SimpleColorSwatch
in Storybook examples
#35179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Components
/packages/components
Storybook
Storybook and its stories for components
[Feature] Component System
WordPress component system
labels
Sep 28, 2021
ciampo
requested review from
youknowriad,
diegohaz,
jorgefilipecosta and
ntsekouras
September 28, 2021 09:58
youknowriad
approved these changes
Sep 28, 2021
Size Change: 0 B Total Size: 1.06 MB ℹ️ View Unchanged
|
aristath
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Component System
WordPress component system
[Package] Components
/packages/components
Storybook
Storybook and its stories for components
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A trivial code change to remove an export from
ItemGroup
s Storybook example — theSimpleColorSwatch
was never meant to be a standalone example, but more of an internal component used by other stories.How has this been tested?
Project builds, Storybook works
Types of changes
Fix (internal to Storybook)
Checklist:
*.native.js
files for terms that need renaming or removal).