Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[RNMobile] Use npm install in React Native e2e tests" #35175

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Revert "[RNMobile] Use npm install in React Native e2e tests" #35175

merged 1 commit into from
Sep 28, 2021

Conversation

fluiddot
Copy link
Contributor

Description

After merging #34886, the workaround introduced in #35111 is no longer required so it would be great if we revert the changes.

How has this been tested?

Verify that "React Native E2E Tests" checks pass.

Screenshots

N/A

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@fluiddot fluiddot added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Sep 28, 2021
@fluiddot fluiddot self-assigned this Sep 28, 2021
@fluiddot fluiddot mentioned this pull request Sep 28, 2021
Merged
7 tasks
@hypest hypest self-requested a review September 28, 2021 09:14
hypest
hypest reviewed Sep 28, 2021
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look perfect!

I'll hold on for the final "Approve" until CI turns green, just to be sure sure.

hypest
hypest approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fluiddot
Copy link
Contributor Author

I updated the following CI testing PR #35108 with these changes for double-checking that the dependencies install doesn't fail when the NPM cache is not present. Once the CI checks pass there I'll merge this PR.

@fluiddot
Copy link
Contributor Author

I updated the following CI testing PR #35108 with these changes for double-checking that the dependencies install doesn't fail when the NPM cache is not present. Once the CI checks pass there I'll merge this PR.

CI checks passed 🟢 so I'm going to merge the PR 🎊 .

@fluiddot fluiddot merged commit a93a961 into trunk Sep 28, 2021
@fluiddot fluiddot deleted the revert-35111-rnmobile/fix/e2e-tests-npm-install branch September 28, 2021 10:44
@github-actions github-actions bot added this to the Gutenberg 11.7 milestone Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

Assignees

@fluiddot fluiddot

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 11.7
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @hypest