Replace tinycolor2 with colord on the bocks package. #35165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Code Quality
|
Size Change: -1.28 kB (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
mtias
reviewed
Sep 28, 2021
| @@ -1,8 +1,10 @@ | |||
| /** | |||
| * External dependencies | |||
| */ | |||
| import { every, has, isFunction, isString, reduce } from 'lodash'; | |||
| import { default as tinycolor, mostReadable } from 'tinycolor2'; | |||
| import { every, has, isFunction, isString, reduce, maxBy } from 'lodash'; | |||
There was a problem hiding this comment.
Curious if this increase in lodash usage counterweights the benefits of colord
There was a problem hiding this comment.
According to our bot, it seems there is still a small reduction:
But I think the main reason for the replacement is colord having first-party typescript types and being more performant in the benchmarks.
There was a problem hiding this comment.
Still good to keep an eye on if there was an intention to reduce the use of lodash
There was a problem hiding this comment.
I guess in this case we can easily avoid the maxBy and use a reduce. But maxBy makes the code more clear (it becomes easy to do what the function is doing) and it internally probably just uses a reduce anyway so the saving would not be noticeable.
jorgefilipecosta
force-pushed
the
update/replace-tinycolor2-with-colord-on-the-blocks-package
branch
from
760c08c to
2ff2db6
Compare
jorgefilipecosta
deleted the
update/replace-tinycolor2-with-colord-on-the-blocks-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tinycolor2 with colord on the blocks package.
How has this been tested?
I used the same test block (https://gist.github.com/jorgefilipecosta/2dd281f9f5f078258f7c8d4ba4cc34cd) created when the icon color functionality was added (on #7068) and verified things still work.