Components: add tests for Navigator*
#35163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
changed the title
Navigator* components
ciampo
added
[Feature] Component System
|
Size Change: +452 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
ciampo
commented
Sep 28, 2021
| */ | ||
| import { Navigator, NavigatorScreen, useNavigator } from '../'; | ||
|
|
||
| jest.mock( 'framer-motion', () => { |
There was a problem hiding this comment.
This is necessary to "ignore" the transitions in the tests
ciampo
requested review from
youknowriad,
ntsekouras,
jorgefilipecosta and
diegohaz
ciampo
changed the title
Navigator* componentsNavigator*
This was referenced Sep 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of a series of smaller PRs that aim at refining the family of
Navigatorcomponents and is part of a larger effort tracked in #34907.This PR adds unit and integration tests for the
Navigator*family of components. The tests are written from the point of view of the end-user, and focus more on the integration of theNavigator*components working as expected, rather than testing the implementation details of every single part in isolation.A future follow-up PR will refactor the components to TypeScript.
How has this been tested?
There are no runtime changes.
Types of changes
New feature (adding tests)
Checklist:
*.native.jsfiles for terms that need renaming or removal).