Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: broken disabled select style in the editor area #35135

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Fix: broken disabled select style in the editor area #35135

merged 1 commit into from
Sep 27, 2021

Conversation

dinhtungdu
Copy link
Contributor

@dinhtungdu dinhtungdu commented Sep 27, 2021

Description

In #30141 we added reset style for select which introduced the multiple arrows background issue for select elements inside the editor. This happens because we didn't "reset" the style correctly for the select:disabled's background. This PR fixes this issue by resetting the select:disabled style following the way it's styled in wp-admin/css/forms.css.

Fixes #35133.

How has this been tested?

  1. Add a new page.
  2. Insert Archives block.
  3. Toggle on Display as dropdown.
  4. See the dropdown styled correctly.

Screenshots

Before:
image

After:
image

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @dinhtungdu! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 27, 2021
@Mamaduka Mamaduka added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement. [Package] Block library /packages/block-library labels Sep 27, 2021
Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirming it fixes the issue. Code changes look good as well. Thanks, @dinhtungdu!

@Mamaduka Mamaduka merged commit 0f1afd5 into WordPress:trunk Sep 27, 2021
@github-actions github-actions bot added this to the Gutenberg 11.7 milestone Sep 27, 2021
@Mamaduka
Copy link
Member

Thanks for working on this fix, @dinhtungdu, and congratulations on your first PR 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken style for disabled dropdown
3 participants