[Server Side Render] Delayed loading state of SSR component #35033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
ntsekouras
requested review from
mcsf,
Mamaduka,
youknowriad,
jasmussen and
fabiankaegy
|
Size Change: +78 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
This seems to me like a great improvement. Here's the spinner not showing up at all because all actions are so fast:
Big fan, thank you for working on this! If you have high confidence in the code, it looks good to me, otherwies it'd be good with another pair of eyes.
Mamaduka
approved these changes
Sep 22, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #35027
This PR shows the loading placeholder of SSR component with a delay of
1 second.It still shows it if there is no previous response(such as when loading the post) and it also shows only the previous response (without the
spinner) if the one second has not passed and there was a previous response obviously 😄 . This way we avoid theflickeringthat used to exist before..Testing instructions
timeout, you can change the timeout to something small (like 10) here