Rename globe icon to url, and update #35032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @getdave since I think you've worked on these bits. This PR is not at all urgent. |
|
Size Change: -358 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
Do I need to update the Link UI component or is backwards compatibility handled somehow? |
|
I've updated the link UI files that referenced the globe icon. We might need a dev note for the npm package publication, but otherwise I don't think we need to do anything? |
|
@jasmussen currently, I don't see Link UI component updates in this PR. It's the reason for failing checks. |
|
Ack! I missed a ton of them 🙈 — thanks all, I'll get on that. |
jasmussen
force-pushed
the
update/globe
branch
from
8a66ca9 to
9f0ca63
Compare
|
So as I found out when editing some of the files was that So I've reverted back to using "globe", and at some point we can do a pass to see what other icons, if necessary, need renames. I know of a few already that diverge between the Figma and the icon package. |
jasmussen
force-pushed
the
update/globe
branch
from
9f0ca63 to
bc06858
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
globeicon was a dashicon, and this PR updates it with new vectors from the WordPress Design Library:Here's how it looked before in the page selector dialog:
Here's after:
The rename from globe to URL is meant to reflect that it should primarily be used for that purpose.
Checklist:
*.native.jsfiles for terms that need renaming or removal).