Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build plugin zip: Verify npm cache before a clean install #34973

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Build plugin zip: Verify npm cache before a clean install #34973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/build-plugin-zip.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ done

# Run the build.
status "Installing dependencies... 📦"
npm cache verify
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been experiencing some issues like the one at https://github.com/WordPress/gutenberg/runs/3654626964?check_suite_focus=true for other npm install and npm ci in GitHub Actions. Tracked at #33424 They seem related to some packages that we point to the GitHub SHA instead of the npm package. When there're network issues, things fall apart.

That was just for context. We can still try doing this to see if it improves the situation for the plugin job.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've tried running the action a number of times and it fails https://github.com/WordPress/gutenberg/actions/runs/1254846943 and https://github.com/WordPress/gutenberg/actions/runs/1254532616

npm ci
status "Generating build... 👷‍♀️"
npm run build
Expand Down