[Inserter]: Pass filter value when clicking Browse All
#34912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
ntsekouras
requested review from
draganescu,
mcsf,
youknowriad,
mtias and
talldan
|
Size Change: +73 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
|
Finally! Excellent addition 😀 thank you! |
ntsekouras
force-pushed
the
add/pass-filtervalue-to-inserter
branch
from
988be40 to
6822b95
Compare
|
Hey good stuff, thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #34607
From the ticket:
This PR implements the second proposed solution:
Testing instructions
Quick inserter, enter a search term and clickBrowse AllScreenshot
Screen.Recording.2021-09-17.at.5.52.30.PM.mov
Notes
__experimentalGetInsertionPointthat is used to pass the filter value might not a very good fit semantically. Should we rename__experimentalGetInsertionPoint? Should I create new actions/selectors, etc...? WDYT?