[Block Library - QueryPagination]: Fix layout support #34897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Package] Block library
ntsekouras
requested review from
youknowriad,
oandregal,
aristath,
gziolo,
kjellr and
jasmussen
|
Size Change: +15 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
aristath
approved these changes
Sep 17, 2021
|
I can confirm that with the flow setting, the next/previous and the numbers are vertical. With flex as the default and because allowSwitching is set to false, should the margins in the block CSS also be removed? |
|
Thanks for reviewing and testing!
Carolina I saw your comment in the other issue and I think @jasmussen , you and other folks more into themes and styling should decide that. This can be done in a separate PR. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a bit sloppy 😞 yesterday with
QueryPaginationflex layout, so this is a follow up for it.While this seemed to work fine with the flex default layout, I didn't make the proper changes to fully support the used
layout. This PR does that.Testing instructions
allowSwitchingtotruein block.jsonflowin theLayoutpanel