Embed: Add Pinterest as an embed provider #34895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pento
added
[Type] Enhancement
|
Size Change: +491 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
gziolo
changed the title
ntsekouras
approved these changes
Sep 17, 2021
There was a problem hiding this comment.
LGTM! Thanks @pento 👍
I've also checked Pinterest brand guidelines and the used icon is good.
|
Actually the previews look all good and the variation related code, but I noticed now that I can't click on the buttons of the preview to do something. There are errors in console like:
|
aristath
approved these changes
Sep 17, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following on from Pinterest being added as a trusted embed provider to WordPress Core (WP53448), this PR adds Pinterest as an embed block provider.
The Pinterest icon is copied from the social-links block.
How has this been tested?
Screenshots
Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).