Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: Update callers to handle when getBlockType returns undefined #34891

Merged

Conversation

amustaque97
Copy link
Member

@amustaque97 amustaque97 commented Sep 16, 2021

This commit has partial changes related to #34462. It is based on some manual testing.

Description

In most cases we either need to check if blockType is truthy before using it, or use optional chaining if it makes sense. eg const icon = blockType?.icon;

How has this been tested?

Testing Instruction can be found here #34346 (comment)

Screenshots

Screenshot 2021-09-17 02:48:48

Types of changes

Fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

cc @gwwar

…fined

This commit has partial changes. It is based on some manual testing.
Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look @amustaque97! I left a few notes since some of the usages have a few gotchas. Feel free to ask if anything I noted was unclear.

packages/block-editor/src/store/actions.js Outdated Show resolved Hide resolved
packages/blocks/src/store/selectors.js Outdated Show resolved Hide resolved
packages/blocks/src/api/factory.js Outdated Show resolved Hide resolved
packages/block-editor/src/components/block-title/index.js Outdated Show resolved Hide resolved
packages/blocks/src/api/factory.js Outdated Show resolved Hide resolved
packages/blocks/src/api/utils.js Outdated Show resolved Hide resolved
Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the code quality improvements @amustaque97! This one is good to land. (All tests are green and things look good with some minor smoke testing).

@gwwar gwwar merged commit e83ec24 into WordPress:trunk Sep 20, 2021
@github-actions github-actions bot added this to the Gutenberg 11.6 milestone Sep 20, 2021
@Mamaduka Mamaduka added [Package] Block editor /packages/block-editor [Type] Code Quality Issues or PRs that relate to code quality labels Sep 20, 2021
@amustaque97 amustaque97 deleted the fix/update-callers-getBlockType-undefined branch September 20, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block editor /packages/block-editor [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants