Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Ensure that all *.asset.php files are included in plugin.zip #34875

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Plugin: Ensure that all *.asset.php files are included in plugin.zip #34875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bin/build-plugin-zip.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,7 @@ build_files=$(
ls build/*/*.{js,css,asset.php} \
build/block-library/blocks/*.php \
build/block-library/blocks/*/block.json \
build/block-library/blocks/*/*.css \
build/block-library/blocks/*/*.js \
build/block-library/blocks/*/*.{js,css,asset.php} \
build/edit-widgets/blocks/*/block.json \
build/widgets/blocks/*.php \
Copy link
Member

@noisysocks noisysocks Sep 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to change this line too?

Copy link
Member Author

@gziolo gziolo Sep 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It warns when files are not present:

Screen Shot 2021-09-17 at 10 10 10

I think this is why the list for edit-widgets and widgets is shorter.

I would appreciate if we could use the following:

build_files=$(
	ls build/*/*.{js,css,asset.php} \
	build/{block-library,edit-widgets,widgets}/blocks/*.php \
	build/{block-library,edit-widgets,widgets}/blocks/*/block.json \
	build/{block-library,edit-widgets,widgets}/blocks/*/*.{js,css,asset.php} \
)

Unless there is a nice way to hide those warnings.

build/widgets/blocks/*/block.json \
Expand Down