Navigation Screen: Correctly display notices #34852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
adamziel,
draganescu,
getdave,
kevin940726,
talldan and
tellthemachines
as code owners
Mamaduka
added
[Feature] Navigation Screen
[Type] Bug
|
Size Change: +8 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new top bar was overlapping the notices on the Navigation screen. PR moves notices inside the interface skeleton content and updated styling to match other editors.
How has this been tested?
Run the following actions using the DevTools console to display notices:
Check that notices don't overlap with block inserter and other elements on the screen.
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).