Block editor: iframe: remove event bubbling and improve draggable chip #34819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +365 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
gwwar
reviewed
Sep 28, 2021
| @@ -51,6 +51,7 @@ $z-layers: ( | |||
|
|
|||
| // The draggable element should show up above the entire UI | |||
| ".components-draggable__clone": 1000000000, | |||
| ".block-editor-block-draggable-chip-wrapper": 1000000000, | |||
There was a problem hiding this comment.
It might be worth using a decimal literal for readability 1_000_000_000
Not sure how important this is, but it looks like the parent z-index stacking context for the chip wrapper is .interface-interface-skeleton__content. This means that despite the high z-index here items in sidebar and actions will be on top of the chip from natural stacking order.
CleanShot.2021-09-28.at.15.44.25.mp4
|
@gwwar Judging by that video, it looks like the chips aren't missing from List View, they're just rendering behind it. |
Good call @ZebulanStanphill that was it: CleanShot.2021-09-30.at.09.49.04.mp4One way of working around this is appending the chip wrapper as a child of body, as we probably want to keep the existing ordering for content vs sidebars and actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dragoverevent on the iframe.BlockToolsnext to the block toolbar (these components are anyway related).__experimentalDragComponentprop can now be removed.Thoughts
While the change requires document level event listeners to be added, we could potentially avoid this with purely React events if we handle it higher up the tree, though document level event handlers might still be required to handle drag end. I thought the block tools would be a more appropriate place for rendering the drag chip.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).