-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: backtick added around <textarea>
input tag in readme file
#34813
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @shohag121! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Looks good to me; thanks for the contribution. |
Hi @ellatrix, Is there anything that this PR needs as an improvement? Thanks. |
Looks like you need to rebuild docs. This can be done with |
Ran Thanks. |
@shohag121 The You can confirm by running that command by itself and then do a The reason it is doing that is because that part of the README.md is auto generated from the source files. To update, you need to update the comments in:
After you update the code comments in those files then run Let me know if that makes sense or if you have additional questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased and applied the changes to the code comments and looks like it is all passing now.
Description
In the Documentation page for
@wordpress/dom
on developer.wordpress.org is broken because of misrendering<input>
and<textarea>
tag.How has this been tested?
Screenshots
Types of changes
Readme text change.
Checklist:
*.native.js
files for terms that need renaming or removal).