Add e2e tests for global inserter to the Navigation Editor screen #34804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
getdave
changed the title
|
Size Change: 0 B Total Size: 1.06 MB ℹ️ View Unchanged
|
Mamaduka
reviewed
Sep 14, 2021
Mamaduka
reviewed
Sep 14, 2021
Mamaduka
approved these changes
Sep 14, 2021
Co-authored-by: George Mamadashvili <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#34619 added the global (sidebar) inserter to the Nav Editor screen.
This PR adds e2e test coverage. We needed to land #34619 to free up other PRs also tackling the top bar before we ended up in a nasty rebase situation.
How has this been tested?
Screenshots
Run
npm run test-e2e packages/e2e-tests/specs/experiments/navigation-editor.test.jsTypes of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).